Conversation
This version of hex.py and hexmap.py has been debugged for python 3. It no longer utilizes utfcsv.py
I updated the readme to account for the changes I've made, and also to account for things I think were mistakes or omissions in the original
Recognized a mistake. Can't just copy any template, needs to be the base template. Changed the readme to reflect this.
|
Your changes will break Python 2 support, correct? Maybe this isn't a big deal as this is the last year we have of python2.7 support. |
|
I haven't tested it with Python 2, but I believe that it will not work with Python 2, given that several of the changes were to account for changes in syntax between Python 2 and 3, and maybe also changes to jinja but I can't remember anymore off-hand. So far I've only tested this on my own windows laptop, does it work for you too? |
|
I haven't had a chance to look yet. I should probably figure out Python 3 support since we're in the last year of Python 2. Would be good if it worked in both, though, which should be doable. |
This version of hex.py and hexmap.py has been debugged for python 3. It no longer utilizes utfcsv.py
I updated the readme to account for the changes I've made, and also to account for things I think were mistakes or omissions in the original
Recognized a mistake. Can't just copy any template, needs to be the base template. Changed the readme to reflect this.
…bracken into max_python3version
|
Do you know how to rebase your changes on top of the latest version of my code? That way you won't have a mix of stuff in your MR, like my dropping Josie's deadname. A little while ago I also updated things to work in Python 3 (53bfb6d) so it's possible your changes might not be needed. Improving the README would still be good, though. |
I do know how to rebase, but I definitely did not understand stuff like that or other git / source control management type stuff when I first forked this 4ish years ago haha so I probably made a mess of things in the first place. I actually am a software engineer now, but at the time I was still learning as I was making a career transition out of academic research in neuroscience (which is where I first started learning ML and which facilitated my transition into MLE). So ya, especially if you've made it python3 compatible anyway, we can probably scrap this other than the README update if it's still relevant, but I can see if there's anything else worth salvaging. If I have time this weekend I can maybe take a closer look. |
2 participants
No description provided.